Sync/videollava#2129
Merged
astachowiczhabana merged 2 commits intoJul 11, 2025
Merged
Conversation
3 tasks
astachowiczhabana
force-pushed
the
v1.19-release
branch
from
79dc01d to
62b45d7
Compare
astachowiczhabana
requested review from
libinta,
mandy-li and
vivekgoe
as code owners
The GaudiVideoLlavaProcessor has been removed from optimum-habana as its functionality is now fully aligned with the upstream Transformers implementation. No custom logic is required, and maintaining a separate class is redundant.
This update aligns the GaudiVideoLlavaForConditionalGeneration implementation with the v4.51.3 transformers changes while retaining `token_idx` argument for compatibility with Gaudi optimizations.
astachowiczhabana
approved these changes
Jul 11, 2025
astachowiczhabana
pushed a commit
that referenced
this pull request
Aug 22, 2025
* Align VideoLlavaProcessor with Transformers v4.51.3 The GaudiVideoLlavaProcessor has been removed from optimum-habana as its functionality is now fully aligned with the upstream Transformers implementation. No custom logic is required, and maintaining a separate class is redundant. * Update GaudiVideoLlavaForConditionalGeneration This update aligns the GaudiVideoLlavaForConditionalGeneration implementation with the v4.51.3 transformers changes while retaining `token_idx` argument for compatibility with Gaudi optimizations.
astachowiczhabana
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Align VideoLlavaProcessor with Transformers v4.51.3 The GaudiVideoLlavaProcessor has been removed from optimum-habana as its functionality is now fully aligned with the upstream Transformers implementation. No custom logic is required, and maintaining a separate class is redundant. * Update GaudiVideoLlavaForConditionalGeneration This update aligns the GaudiVideoLlavaForConditionalGeneration implementation with the v4.51.3 transformers changes while retaining `token_idx` argument for compatibility with Gaudi optimizations.
astachowiczhabana
pushed a commit
that referenced
this pull request
Sep 10, 2025
* Align VideoLlavaProcessor with Transformers v4.51.3 The GaudiVideoLlavaProcessor has been removed from optimum-habana as its functionality is now fully aligned with the upstream Transformers implementation. No custom logic is required, and maintaining a separate class is redundant. * Update GaudiVideoLlavaForConditionalGeneration This update aligns the GaudiVideoLlavaForConditionalGeneration implementation with the v4.51.3 transformers changes while retaining `token_idx` argument for compatibility with Gaudi optimizations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GaudiVideoLlavaProcessor has been removed from optimum-habana as its functionality is now fully aligned with the v4.51.3 Transformers implementation. No custom logic is required, and maintaining a separate class is redundant.
Update GaudiVideoLlavaForConditionalGeneration implementation with the v4.51.3 transformers changes while retaining
token_idxargument for compatibility with Gaudi optimizations.The
masked_scatteris not a bottleneck on G3 anymore.Fixes # (issue)
Before submitting